Skip to content

api: fix EntityReference in NetworkResponse.java#10563

Merged
weizhouapache merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-NetworkResponse
Mar 18, 2025
Merged

api: fix EntityReference in NetworkResponse.java#10563
weizhouapache merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-NetworkResponse

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Mar 13, 2025

Description

This PR...

Prior to this PR


(localcloud) 🐱 > delete network id=bb7268b8-2ded-4548-b67e-e275808dae0f
🙈 Error: (HTTP 431, error code 4350) Network ID=47 doesn't exist
(localcloud) 🐱 > delete network id=bb7268b8-2ded-4548-b67e-e275808dae0f
🙈 Error: (HTTP 431, error code 4350) Network ID=35 doesn't exist
(localcloud) 🐱 > delete network id=bb7268b8-2ded-4548-b67e-e275808dae0f
🙈 Error: (HTTP 431, error code 4350) Network ID=51 doesn't exist
(localcloud) 🐱 > delete network id=bb7268b8-2ded-4548-b67e-e275808dae0f
🙈 Error: (HTTP 431, error code 4350) Network ID=23 doesn't exist
(localcloud) 🐱 > delete network id=bb7268b8-2ded-4548-b67e-e275808dae0f
🙈 Error: (HTTP 431, error code 4350) Network ID=19 doesn't exist
(localcloud) 🐱 > delete network id=bb7268b8-2ded-4548-b67e-e275808dae0f
🙈 Error: (HTTP 431, error code 4350) Network ID=83 doesn't exist
(localcloud) 🐱 > delete network id=bb7268b8-2ded-4548-b67e-e275808dae0f
🙈 Error: (HTTP 431, error code 4350) Network ID=79 doesn't exist
(localcloud) 🐱 > delete network id=bb7268b8-2ded-4548-b67e-e275808dae0f
🙈 Error: (HTTP 431, error code 4350) Network ID=79 doesn't exist
(localcloud) 🐱 > delete network id=bb7268b8-2ded-4548-b67e-e275808dae0f
🙈 Error: (HTTP 431, error code 4350) Network ID=19 doesn't exist
(localcloud) 🐱 > delete network id=bb7268b8-2ded-4548-b67e-e275808dae0f
🙈 Error: (HTTP 431, error code 4350) Network ID=51 doesn't exist

with this PR

(localcloud) 🐱 > delete network id=bb7268b8-2ded-4548-b67e-e275808dae0f
🙈 Error: (HTTP 431, error code 9999) Unable to execute API command deletenetwork due to invalid value. Invalid parameter id value=bb7268b8-2ded-4548-b67e-e275808dae0f due to incorrect long value format, or entity does not exist or due to incorrect parameter annotation for the field in api cmd class.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.19.3 milestone Mar 13, 2025
@codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.16%. Comparing base (95c2481) to head (b3db14a).
Report is 4 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10563   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11326    11327    +1     
=========================================
  Files          5414     5414           
  Lines        474804   474804           
  Branches      57909    57909           
=========================================
+ Hits          72002    72010    +8     
+ Misses       394749   394743    -6     
+ Partials       8053     8051    -2
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Mar 13, 2025

Can you explain a bit more @weizhouapache , does the network actually not exist? It seems from the description this is hardly an improvement , but I deduce an error message is wanted in this case.

@weizhouapache
Copy link
Member Author

weizhouapache commented Mar 13, 2025

Can you explain a bit more @weizhouapache , does the network actually not exist? It seems from the description this is hardly an improvement , but I deduce an error message is wanted in this case.

@DaanHoogland
the network does not exist.
strangely I was able to reproduce the issue on one of my envs, but not on another env.

anyway, it does not make any sense to add "ProjectAccount.class" as the entity reference.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Mar 14, 2025

anyway, it does not make any sense to add "ProjectAccount.class" as the entity reference.

agreed

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Mar 14, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 14, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 14, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12780

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Mar 14, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Mar 14, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Mar 15, 2025

[SF] Trillian test result (tid-12696)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46214 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10563-t12696-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_secure_vm_migration Error 280.30 test_vm_life_cycle.py

@weizhouapache weizhouapache merged commit 7978141 into apache:4.19 Mar 18, 2025
25 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@weizhouapache @dhslove
api: fix EntityReference in NetworkResponse.java (apache#10563)
14b4f9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

No one assigned

Labels

component:api

Projects

None yet

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

4 participants

@weizhouapache @DaanHoogland @blueorangutan @Pearl1594